[PATCH] [trivial] don't rely on implicit int return type
David Disseldorp
ddiss at samba.org
Sun Jan 27 20:42:47 UTC 2019
On Sun, 27 Jan 2019 18:36:01 +0100, Andreas Schneider wrote:
> On Sunday, 27 January 2019 14:15:08 CET David Disseldorp via samba-technical
> wrote:
> > The attached patchset fixes a few minor C99 compiler warnings.
>
> RB+, but you should split the first patch into two as it also does reformating
> and I looked at the first hunk and then got confused because the commit
> message said something different :-)
Thanks, will split and push to gitlab with your RB.
FWIW, I thought we normally reject separate formatting changes, with the
reason that it'll eventually be fixed with code changes in the area :)
Cheers, David
More information about the samba-technical
mailing list