configure: selftest vs developer

[Isaac Boukris]

On Fri, Jan 25, 2019 at 11:42 AM Ralph Böhme <slow at samba.org> wrote:
>
> On Thu, Jan 24, 2019 at 10:53:42PM +0200, Isaac Boukris via samba-technical wrote:
> >According to 'selftest/wscript' developer already implies selftest, so
> >maybe we just need to change DEVELOPER to ENABLE_SELFTEST whenever it
> >is required for running the tests?
>
> I only skimmed the discussion in this thread so I might be missing something,
> but I wanted to point out that --enable-developer triggers a boatload of other
> stuff, it's not just enabling selftest.

Yea, but iff enable-developer always sets ENABLE_SELFTEST, then we can
ifdef ENABLE_SELFTEST only. Or in other words, my proposed patch can
be made as attached.
Pipeline (running): https://gitlab.com/samba-team/devel/samba/pipelines/44772036
-------------- next part --------------
From 77fd0bac6d89f96cba473bf641750b365c7ad393 Mon Sep 17 00:00:00 2001
From: Isaac Boukris <iboukris at gmail.com>
Date: Thu, 24 Jan 2019 12:31:27 +0200
Subject: [PATCH] Fix tests when building with selftest but without developer

Signed-off-by: Isaac Boukris <iboukris at gmail.com>
---
 libcli/dns/dns_lookup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcli/dns/dns_lookup.c b/libcli/dns/dns_lookup.c
index 7402d443fba..cb0ede80f98 100644
--- a/libcli/dns/dns_lookup.c
+++ b/libcli/dns/dns_lookup.c
@@ -70,7 +70,7 @@ struct tevent_req *dns_lookup_send(TALLOC_CTX *mem_ctx,
 	if (resolv_conf_fp == NULL) {
 		const char *resolvconf = "/etc/resolv.conf";
 
-#ifdef DEVELOPER
+#ifdef ENABLE_SELFTEST
 		{
 			const char *envvar = getenv("RESOLV_CONF");
 			if (envvar != NULL) {
-- 
2.14.4