[PATCH] python indent bugfix in dns_hub.py

Jeremy Allison jra at samba.org
Thu Jan 24 18:44:59 UTC 2019

On Thu, Jan 24, 2019 at 12:48:03PM +0200, Isaac Boukris wrote:
> Hi,
> On Wed, Jan 23, 2019 at 6:53 PM Jeremy Allison <jra at samba.org> wrote:
> >
> > Yeah, this is starting to look like something strange in your
> > local environment.
> I think I figured out what's wrong in my environment. My main sin is
> building with selftest only, without developer option. Though unlike
> what I thought before, it wasn't due to timing but due to not using
> the right resolv.conf file. Attached patch fixes it for me, please
> take a look.

Hmmm. That looks correct to me, but I wonder how many
other dependencies there are that assume DEVELOPER==ENABLE_SELFTEST.

Maybe we should just make one dependent on the other ?

> Unfortunately this does not help for the gitlab issues which do seem
> timing related, as I think we always use developer option on gitlab.
> Also note that after pushing the retry patch to my branch (merge
> request 200), I still got a failure similar to the one Metze has
> described, see:
> https://gitlab.com/samba-team/devel/samba/-/jobs/150165046
> It was solved upon retrying, and I finally got the green mark.

Yeah, metze nailed the underlying cause I think,
which is the interaction between dns_hub and the
resolv wrapper. If I get time before FOSDEM I'll
try and take a look.

More information about the samba-technical mailing list