[PATCH] Fix crash bug in smbd when adding 'force group' on existing connection.

[Jeremy Allison]

Hi Ralph,

Attached is a regression test plus a patch
for bug: https://bugzilla.samba.org/show_bug.cgi?id=13690
that was reported by several Linux vendors.

The bug is an smbd crash if a share
has no 'force group' definition and
a client is connected to the share,
then the admin adds a 'force group' definition
to the share in smb.conf. Next operation
by the client triggers a server crash.

It's not a DoS as it requires an admin
to modify smb.conf to trigger the crash.

The fix is to not expect client credentials
to change in this circumstance and stay
with the existing credentials (which is
what already happens for a share with an
existing 'force group' definition that
is changed whilst an existing connection
is in place).

The fix has been tested and reported to
fix the problem by Canonical.

Please review and push if happy !

Cheers,

	Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug-13690-master.patch
Type: text/x-diff
Size: 9354 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190124/b35d9ea9/bug-13690-master.diff>