[PATCH] CI: put back lost nt4 target to gitlab CI

[Andrew Bartlett]

On Wed, 2019-01-23 at 21:18 +0200, Isaac Boukris wrote:
> Hi Ralph,
> 
> On Tue, Jan 22, 2019 at 4:04 PM Ralph Böhme via samba-technical
> <samba-technical at lists.samba.org> wrote:
> > 
> > 
> > Hi folks,
> > 
> > I noticed that the nt4_dc and member envs have been lost from the
> > .gitlab*.yml
> > config files in the recent Python reshuffling. The attached patch
> > puts it back
> > in.
> > 
> > I've added it to the public runners as it doesn't run overly long.
> I get a yaml syntax error upon rebasing on master, see:
> https://gitlab.com/samba-team/devel/samba/pipelines/44531194
> 
> Perhaps it should be shared_template as the others around? Note that
> I
> may not have the same level of access on gitlab.

You are correct, the private_template is only for use (and only
declared in) .gitlab-ci-private.yml

Ralph,

I didn't see a pull request, did this go via GitLab CI?

(This is why pull requests are such a great thing, a really strong tie
between patches and the CI results).

Furthermore, it looks from c9764342c2f67983a037714110913dafe0dba59e
that samba-nt4 needs to be in the private runners, because while it is
fast, it needs an ext4 (not unionfs) filesystem to pass.

Can you please re-submit a fixed patch via a pull request?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba