[PATCH] python indent bugfix in dns_hub.py

Stefan Metzmacher metze at samba.org
Wed Jan 23 18:06:21 UTC 2019

Am 23.01.19 um 02:07 schrieb Jeremy Allison via samba-technical:
> On Wed, Jan 23, 2019 at 12:54:21PM +1300, Tim Beale wrote:
>> I looked more closely at the failed logs. It appears that the slow DNS
>> reply is not because the DC has only just started up.
>> E.g. in Isaac's log, the very first test case is run successfully
>> against the fl2000dc. It's not until ~24 minutes later that we try to
>> start the vampire_2000_dc and join it to fl2000dc.
>> https://gitlab.com/samba-team/devel/samba/-/jobs/148388249
>> So I don't think putting a check in wait_for_start() would help avoid
>> this problem.

I saw problems with the wait_for_start() of vampire_*_dc itself.
And the problem is that it hasn't registered its own names yet.
But we seem to have multiple problems here...

> Here is my test python-retry patchset. As per Metze's instructions
> DO NOT PUSH ! :-).
> I'm running it in gitlab-ci right now, and wondered if you could
> see if it fixes Isaac's issues ?

If we really want retries we should have them at the C code layer.
E.g. the dns lookup code, glibc seems to try 3 queries with a timeout
of 5 seconds by default.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190123/d7ed3342/signature.sig>

More information about the samba-technical mailing list