[PATCH] Fix compilation error with vfs_glusterfs

Martin Schwenke martin at meltin.net
Wed Jan 23 05:41:37 UTC 2019


On Wed, 23 Jan 2019 09:24:50 +0530, Anoop C S via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Wed, 2019-01-23 at 11:58 +1100, Amitay Isaacs wrote:

> > On Wed, Jan 23, 2019 at 4:03 AM Anoop C S via samba-technical
> > <samba-technical at lists.samba.org> wrote:  
> > > On Tue, 2018-03-20 at 16:35 +0530, Anoop C S wrote:  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
> > > 
> > > Attaching the modified version as underlying GlusterFS API
> > > signatures
> > > have been finalized recently.
> > >   
> > 
> > While you are fixing this issue, would you also fix the build problem
> > on freebsd?
> > 
> > [3398/3906] Compiling source3/modules/vfs_glusterfs_fuse.c
> > ../../source3/modules/vfs_glusterfs_fuse.c:45:16: error: use of
> > undeclared identifier 'ENODATA'
> >                 if (errno == ENODATA) {
> >                              ^
> > 1 error generated.
> > 
> > As you can see, on freebsd ENODATA is not defined.  
> 
> Please see the attached patch which adds a generic #ifndef for ENODATA.
> I hope this need not be platform specific especially in this particular
> context where error returned for getxattr() is validated.
> 
> I have also added check for ENOATTR considering platforms which
> directly return ENOATTR for getxattr() in the absence of an extended
> attribute. ENOATTR should be always defined based on the following
> #ifndef from source3/includes/includes.h
> 
> ...
> #ifndef ENOATTR
> #if defined(ENODATA)
> #define ENOATTR ENODATA
> #else
> #define ENOATTR ENOENT
> #endif
> #endif
> ...

Yep, that fixes the build on FreeBSD!

Reviewed-by: Martin Schwenke <martin at meltin.net>

Another team reviewer please?

Thanks...

peace & happiness,
martin



More information about the samba-technical mailing list