[PATCH] python indent bugfix in dns_hub.py

Andrew Bartlett abartlet at samba.org
Wed Jan 23 01:21:58 UTC 2019

On Tue, 2019-01-22 at 21:32 +0100, Stefan Metzmacher wrote:
> Am 22.01.19 um 18:02 schrieb Jeremy Allison via samba-technical:
> > 
>> > FYI, Changing DNS_REQUEST_TIMEOUT to 5 passed gitlab-ci
> > for me.
> > 
> > https://gitlab.com/samba-team/devel/samba/pipelines/44257355
> > 
> > I think a combination of this change plus adding retries
> > in the join.py code should do the trick.
> I'd really like to avoid retries in command line code,
> this should just work without them. If we have problems
> in our selftest environment, we should have retries in
> selftest/target/Samba4.pm: wait_for_start() to make sure everything
> is
> ready.

Why is that?  Shouldn't we ensure our command-line tools are script
safe in the presence of a little packet loss in production?

I agree selftest-only problems should be addressed at a higher level,
but I don't quite understand your rationale for the above. 

Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list