[PATCH] python indent bugfix in dns_hub.py

[Stefan Metzmacher]

Am 22.01.19 um 18:02 schrieb Jeremy Allison via samba-technical:
> On Tue, Jan 22, 2019 at 09:54:06AM +0200, Isaac Boukris via samba-technical wrote:
>>>
>>> The 2 second thing was nagging at me. Checking
>>> libcli/dns/dns.c we have:
>>>
>>> #define DNS_REQUEST_TIMEOUT 2
>>
>> FYI, changing DNS_REQUEST_TIMEOUT to 10 or to 30 does not help in my
>> local reproduction.
>>
>> I think timeouts might sometimes be ignored when receiving a network
>> error such as port unreachable an so.
> 
> FYI, Changing DNS_REQUEST_TIMEOUT to 5 passed gitlab-ci
> for me.
> 
> https://gitlab.com/samba-team/devel/samba/pipelines/44257355
> 
> I think a combination of this change plus adding retries
> in the join.py code should do the trick.

I'd really like to avoid retries in command line code,
this should just work without them. If we have problems
in our selftest environment, we should have retries in
selftest/target/Samba4.pm: wait_for_start() to make sure everything is
ready.

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190122/5beffbc5/signature.sig>