[PATCH] python indent bugfix in dns_hub.py

Jeremy Allison jra at samba.org
Tue Jan 22 17:02:14 UTC 2019


On Tue, Jan 22, 2019 at 09:54:06AM +0200, Isaac Boukris via samba-technical wrote:
> >
> > The 2 second thing was nagging at me. Checking
> > libcli/dns/dns.c we have:
> >
> > #define DNS_REQUEST_TIMEOUT 2
> 
> FYI, changing DNS_REQUEST_TIMEOUT to 10 or to 30 does not help in my
> local reproduction.
> 
> I think timeouts might sometimes be ignored when receiving a network
> error such as port unreachable an so.

FYI, Changing DNS_REQUEST_TIMEOUT to 5 passed gitlab-ci
for me.

https://gitlab.com/samba-team/devel/samba/pipelines/44257355

I think a combination of this change plus adding retries
in the join.py code should do the trick.

Jeremy.



More information about the samba-technical mailing list