[PATCH] add vfs_glusterfs_fuse module

Ralph Böhme slow at samba.org
Tue Jan 22 14:13:49 UTC 2019


Hi Günther,

On Tue, Jan 22, 2019 at 11:01:39AM +0100, Günther Deschner via samba-technical wrote:
>please review & push.

with the attached fixup applied: reviewed-by-me.

-slow

-- 
Ralph Boehme, Samba Team                https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46
-------------- next part --------------
From 8910609a27de329e213b9038e91f3581261958f2 Mon Sep 17 00:00:00 2001
From: Ralph Boehme <slow at samba.org>
Date: Tue, 22 Jan 2019 15:12:28 +0100
Subject: [PATCH] fixup

---
 source3/modules/vfs_glusterfs_fuse.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/source3/modules/vfs_glusterfs_fuse.c b/source3/modules/vfs_glusterfs_fuse.c
index 41669e79f5b..64c1b0035c1 100644
--- a/source3/modules/vfs_glusterfs_fuse.c
+++ b/source3/modules/vfs_glusterfs_fuse.c
@@ -25,11 +25,12 @@ static int vfs_gluster_fuse_get_real_filename(struct vfs_handle_struct *handle,
 					      const char *path,
 					      const char *name,
 					      TALLOC_CTX *mem_ctx,
-					      char **found_name)
+					      char **_found_name)
 {
 	int ret;
 	char key_buf[NAME_MAX + 64];
 	char val_buf[NAME_MAX + 1];
+	char *found_name = NULL;
 
 	if (strlen(name) >= NAME_MAX) {
 		errno = ENAMETOOLONG;
@@ -47,11 +48,12 @@ static int vfs_gluster_fuse_get_real_filename(struct vfs_handle_struct *handle,
 		return -1;
 	}
 
-	*found_name = talloc_strdup(mem_ctx, val_buf);
-	if (found_name[0] == NULL) {
+	found_name = talloc_strdup(mem_ctx, val_buf);
+	if (found_name == NULL) {
 		errno = ENOMEM;
 		return -1;
 	}
+	*_found_name = found_name;
 	return 0;
 }
 
-- 
2.17.2



More information about the samba-technical mailing list