[PATCH] python indent bugfix in dns_hub.py

[Jeremy Allison]

On Tue, Jan 22, 2019 at 05:37:26PM +1300, Tim Beale wrote:
> I'm not sure this patch really helps. My CI builds are still hitting the
> error, it's just now it looks more like this:
> 
> > INFO 2019-01-22 17:12:44,430 pid:95958 bin/python/samba/join.py #103:
> > Finding a writeable DC for domain 'SAMBA2000.EXAMPLE.COM'
> > dns_hub: sending 127.0.0.25 to address ('127.0.0.39', 55960) for name
> > _ldap._tcp.SAMBA2000.EXAMPLE.COM
> >
> > Error sending 127.0.0.25 to address ('127.0.0.39', 55960) for name
> > _ldap._tcp.SAMBA2000.EXAMPLE.COM: [Errno 113] No route to host
> >
> > ERROR: Failed to find a writeable DC for domain
> > 'SAMBA2000.EXAMPLE.COM': The object name is not found.
> > Join failed
> 
> E.g. https://gitlab.com/catalyst-samba/samba/-/jobs/148978423
> 
> I think the join code is essentially calling finddcs_cldap() using the
> domain name, which does a DNS lookup. Because the DNS lookup fails, so
> does the join, and so the testenv can't be created.
> 
> If I put a 2 second sleep in dns_transaction_udp(), then I see the exact
> same failure locally. Which suggest to me we're hitting this because
> finddcs_cldap() has timed out, samba-tool has given up and exited, and
> so the client no longer exists for sock.sendto() to send the DNS
> response back to.
> 
> I'm guessing this could either be happening because the DC's DNS server
> process is slow to process the query (because the DC only just started
> up), or the CI machine is just heavily loaded and so it takes a while to
> proxy the DNS query/response back and forth between the DC and client.

Great work Tim ! Could we fix this by adding
retries to finddcs_cldap() ?

Jeremy.