[PATCH] Convert auth_log tests to use s3 SMB Py bindings
timbeale at catalyst.net.nz
Mon Jan 21 21:33:31 UTC 2019
Yes, the CI problem was the flappy dns_hub problem, which should now be
avoided by Douglas's change. Sorry, I didn't realize you couldn't see
the CI failure details for that project.
Thanks for the reviews everyone.
On 18/01/19 11:07 PM, Noel Power wrote:
> On 18/01/2019 09:43, Noel Power via samba-technical wrote:
>> On 16/01/2019 03:24, Tim Beale via samba-technical wrote:
>>> This converts the auth_log tests over to use the s3 SMB client Python
>>> The auth_log tests and the GPO code are the last 2 things that uses the
>>> s4 bindings. Once those 2 patch-sets are in, we should be able to delete
>>> the redundant s4 pysmb.c bindings in master.
>>> CI link: https://gitlab.com/catalyst-samba/samba/pipelines/43497816
>> This looks good to me, however the CI has failed on catalyst gitlab and
>> I am not able to see the logs to determine if this is like I suspect a
>> flapping test that is the problem. I'm going to run the failing job
>> again on devel/samba gitlab Assuming it passes I'll push the to autobuild
> strike that, seems this is already merged
More information about the samba-technical