[PATCH] ldb: Use deterministic order of dict for tests

Andrew Bartlett abartlet at samba.org
Mon Jan 21 20:19:15 UTC 2019


On Mon, 2019-01-21 at 19:50 +0100, Lukas Slebodnik via samba-technical
wrote:
> 
> I spent more time debugging it on s390x and I can say that there is
> not any
> issue with passing env PYTHONHASHSEED to the test.
> 
> The problem is with the value of env PYTHONHASHSEED.
> 
> It deterministically fails with the value 1.
> 
> So is there any reason why you insist on the value 1.
> IMHO value 0 for PYTHONHASHSEED is perfectly valid and works on all
> architectures in fedora
> https://koji.fedoraproject.org/koji/buildinfo?buildID=1180702
> 
> I can send a patch to change all values from 1 -> 0 if there are not
> any
> objection.

I would really prefer to understand where the issue really comes from
if at all possible, this is just getting even more strange and changing
magic numbers.  Even specifying PYTHONHASHSEED was meant to be a very
short term hack, not a long-term solution, but so far a proper solution
has been elusive...

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list