[PATCH] python indent bugfix in dns_hub.py

Andrew Bartlett abartlet at samba.org
Sun Jan 20 18:06:31 UTC 2019

On Fri, 2019-01-18 at 12:49 -0800, Jeremy Allison via samba-technical
> On Sat, Jan 19, 2019 at 09:44:59AM +1300, Douglas Bagnall wrote:
> > 
> > What we have managed so far is to crash with the correct message
> > when
> > a client disappears, but a more conventional approach might be to
> > note
> > the problem and keep going. This patch wants to do that.
> LGTM. I was the one who added the raise in the first place,
> and I'm OK with removing it. Although I'd really like to
> know *why* the client is disappearing in the tests (which
> is why I added the raise initially to try and track it down).
> > 
> > I am not sure what the underlying cause is. The quoted example
> > from https://gitlab.com/samba-team/devel/samba/-/jobs/147653485
> It's intermittent, that's the problem. Mostly it doesn't
> happen, I'd really like to know why it sometimes does :-(.

Me too.  But I've pushed the patch anyway.

Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list