[PATCH] s3:libsmb: Store file allocation size in struct file_info.

Jeremy Allison jra at samba.org
Fri Jan 18 01:01:56 UTC 2019


On Thu, Jan 17, 2019 at 04:18:56PM -0800, Jeremy Allison wrote:
> Hi Puran,
> 
> I think your patch is good except rather than
> using ino_t in the internal struct file_info,
> I'd rather keep it as the uint64_t type the
> on-the-wire call actually returns. We can
> always map it to ino_t in the libsmbclient
> public interface, but right now I don't
> want to lose any possible info.
> 
> Let me know if you're good with this
> and I'll push.

Second part - return uint64_t allocated_size
in struct file_info as well as we get it
for free. Leave as zero for SMB1.

Andreas, please review and push if happy.

Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-libsmb-Store-file-allocation-size-in-struct-file_.patch
Type: text/x-diff
Size: 1551 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190117/6520f23a/0001-s3-libsmb-Store-file-allocation-size-in-struct-file_.diff>


More information about the samba-technical mailing list