merge request 187 on GitLab
jra at samba.org
Thu Jan 17 19:01:00 UTC 2019
On Thu, Jan 17, 2019 at 09:54:46AM -0800, Jeremy Allison via samba-technical wrote:
> On Thu, Jan 17, 2019 at 03:57:26PM +0100, Martin Krämer via samba-technical wrote:
> > Hi all,
> > some days ago I have created a merge request for a samba-tool patch on
> > GitLab.
> > I created this based on instructions from:
> > https://wiki.samba.org/index.php/Samba_CI_on_gitlab
> > and
> > https://wiki.samba.org/index.php/Using_Git_for_Samba_Development
> > Never the less this is my first contribution to samba and my first work
> > with GitLab - I am not sure if I have done everything correct or if there
> > are further actions required by me to be merged.
> > The merge request is:
> > https://gitlab.com/samba-team/samba/merge_requests/187
> > Thanks for instructions
> Most of the Samba Team members still look for new patches
> as attachments on the samba-technical mailing list. It's
> always good to send them there as well as on gitlab (which
> we use mostly for CI work, not merging).
> Having said that your patch looks good to me !
> Reviewed-by: Jeremy Allison <jra at samba.org>
> Can I get a second Team reviewer ?
> Thanks a *lot* for helping us with Samba !
A couple of quick things.
1). Are you OK with me adding a 'Signed-off-by: Martin Krämer <mk.maddin at gmail.com>
line to the patch ? We require that to keep the provenence of
all patch submissions (and it's really helpful when generating
patches so I don't have to keep asking :-). You can do it
from git by adding the -s option when you commit the patch
to your repo.
2). If you're going to work on Samba some more, it'd
we worthwhile to send in the contributors agreement
as outlined here:
More information about the samba-technical