merge request 187 on GitLab
jra at samba.org
Thu Jan 17 17:54:46 UTC 2019
On Thu, Jan 17, 2019 at 03:57:26PM +0100, Martin Krämer via samba-technical wrote:
> Hi all,
> some days ago I have created a merge request for a samba-tool patch on
> I created this based on instructions from:
> Never the less this is my first contribution to samba and my first work
> with GitLab - I am not sure if I have done everything correct or if there
> are further actions required by me to be merged.
> The merge request is:
> Thanks for instructions
Most of the Samba Team members still look for new patches
as attachments on the samba-technical mailing list. It's
always good to send them there as well as on gitlab (which
we use mostly for CI work, not merging).
Having said that your patch looks good to me !
Reviewed-by: Jeremy Allison <jra at samba.org>
Can I get a second Team reviewer ?
Thanks a *lot* for helping us with Samba !
More information about the samba-technical