[PATCH] Fix debug message in gencache

Andreas Schneider asn at samba.org
Thu Jan 17 13:49:01 UTC 2019


On Thursday, January 17, 2019 2:12:59 PM CET Volker Lendecke wrote:
> On Thu, Jan 17, 2019 at 02:05:27PM +0100, Andreas Schneider via samba-
technical wrote:
> > Hi,
> > 
> > here is a small patch to fix a debug message.
> 
> Looks good, RB+.
> 
> Question: Why not cast to time_t?

The value can be negative so we should use a signed integer space for the 
subtraction. Currently we do it in time_t and then cast it to int which 
results in a message:

 timeout (-1547089989 seconds in the past)

which translates into roughly 17000 days. This is a bit much ...


	Andreas

-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D





More information about the samba-technical mailing list