[PATCH] Fix untidy samba-tool exception handling
jra at samba.org
Wed Jan 16 17:46:08 UTC 2019
On Wed, Jan 16, 2019 at 09:41:28AM +0000, Rowland Penny via samba-technical wrote:
> On Wed, 16 Jan 2019 16:35:17 +1300
> Tim Beale via samba-technical <samba-technical at lists.samba.org> wrote:
> > During a join, our exception handling was throwing an exception. The
> > resulting samba-tool output wasn't particularly user-friendly. I
> > spotted this problem during a failed CI autobuild run.
> > Attached is a fix. I also raised a bug for backporting it:
> > https://bugzilla.samba.org/show_bug.cgi?id=13747
> > CI link: https://gitlab.com/catalyst-samba/samba/pipelines/43503776
> > Review appreciated, thanks.
> Whilst it looks good to me, you have lines greater than 80 columns and
> I sort of thought we were moving from '%s' to .format
Perfect is the enemy of the good in this case :-).
More information about the samba-technical