[PATCH] vfs_fileid: fix fsname_norootdir algorithm

[Volker Lendecke]

On Tue, Jan 15, 2019 at 05:35:03PM +0100, Ralph Wuerthner wrote:
> Hi Volker!
> 
> On 15.01.19 15:58, Volker Lendecke wrote:
> > On Tue, Jan 15, 2019 at 11:50:57AM +0100, Ralph Wuerthner via samba-technical wrote:
> > > Hi list!
> > > 
> > > Please see attached patchset to fix the fsname_norootdir algorithm in the
> > > VFS fileid module. I already opened Samba bugzilla 13744 because this is
> > > broken since Samba 4.8.
> > 
> > RB+ on the first patch "fix fsname_norootdir". I'm not sure about the
> > second one. What happens if you explicitly set the fileid:nolockinode
> > parameter to do the hostname algorithm for a file somewhere in the
> > share, not the root?
> > 
> > Volker
> > 
> 
> You are right. I overlooked that data->nolockinode can be set via
> "fileid:nolockinode" and I'm withdrawing the second patch. Please see the
> updated patch.

Pushed together with Ralph B's review.

Thanks!

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de