[PATCH] remove nt_errstr_const()

Philipp Gesang philipp.gesang at intra2net.com
Wed Jan 16 10:51:42 UTC 2019


Hi,

I noticed what appears to be an oversight in ntstatus.h:
nt_errstr_const() was removed with commit b341979adb in 2011 but
the declaration was left intact.

FWIW the CI: https://gitlab.com/phgsng/samba/pipelines/43533479

Regards,
Philipp

-------------- next part --------------
From 54dca5c139cd781d2196a8ee9e81950efd35deeb Mon Sep 17 00:00:00 2001
From: Philipp Gesang <philipp.gesang at intra2net.com>
Date: Wed, 16 Jan 2019 10:01:28 +0100
Subject: [PATCH] libcli: remove declaration of nt_errstr_const

nt_errstr_const was renamed nt_errstr in 2011, rendering the
declaration useless.

Signed-off-by: Philipp Gesang <philipp.gesang at intra2net.com>
---
 libcli/util/ntstatus.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/libcli/util/ntstatus.h b/libcli/util/ntstatus.h
index e24d6eb9843..4b5f1ca1802 100644
--- a/libcli/util/ntstatus.h
+++ b/libcli/util/ntstatus.h
@@ -102,15 +102,6 @@ typedef uint32_t NTSTATUS;
  * this means we need a torture test */
 #define NT_STATUS_FOOBAR NT_STATUS_UNSUCCESSFUL
 
-/*****************************************************************************
- Returns an NT error message.  not amazingly helpful, but better than a number.
-
- This version is const, and so neither allocates memory nor uses a
- static variable for unknown errors.
- *****************************************************************************/
-
-const char *nt_errstr_const(NTSTATUS nt_code);
-
 /*****************************************************************************
  returns an NT error message.  not amazingly helpful, but better than a number.
  *****************************************************************************/
-- 
2.17.2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190116/8c31fc79/signature.sig>


More information about the samba-technical mailing list