[PATCH] Add "locks_latency" to "ctdb -Y statistics"

[Volker Lendecke]

On Tue, Jan 15, 2019 at 10:00:56PM +1100, Martin Schwenke via samba-technical wrote:
> On Tue, 15 Jan 2019 08:42:24 +0100, Volker Lendecke
> <Volker.Lendecke at SerNet.DE> wrote:
> 
> > On Tue, Jan 15, 2019 at 10:04:53AM +1100, Martin Schwenke wrote:
> > > On Mon, 14 Jan 2019 15:16:39 +0100, Volker Lendecke via samba-technical
> > > <samba-technical at lists.samba.org> wrote:
> > >   
> > > > Review appreciated!  
> > > 
> > > Oh, wow!  That is (now) obviously missing...
> > > 
> > > The if-statement above the hunk in your patch prints headers, which
> > > includes already *_lockwait_latency.  It is between *_call_latency and
> > > *_childwrite_latency.
> > > 
> > > This means you need to print the s->locks.latency.* values between where
> > > the s->call_latency.* and s->childwrite_latency.* are printed.  You've
> > > printed them first.  :-)  
> > 
> > To be honest, I was completely confused about the precise meaning. So
> > put it wherever it's required :-)
> 
> I think you want the attached patch to make the values consistent with
> the header.  Please sanity check because I'm 1/2 asleep.  :-)
> 
> Attached patch already has:
> 
> Reviewed-by: Martin Schwenke <martin at meltin.net>

Ok, pushed. Thanks!

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de