[PATCH] Add "locks_latency" to "ctdb -Y statistics"

Martin Schwenke martin at meltin.net
Mon Jan 14 23:04:53 UTC 2019


On Mon, 14 Jan 2019 15:16:39 +0100, Volker Lendecke via samba-technical
<samba-technical at lists.samba.org> wrote:

> Review appreciated!

Oh, wow!  That is (now) obviously missing...

The if-statement above the hunk in your patch prints headers, which
includes already *_lockwait_latency.  It is between *_call_latency and
*_childwrite_latency.

This means you need to print the s->locks.latency.* values between where
the s->call_latency.* and s->childwrite_latency.* are printed.  You've
printed them first.  :-)

peace & happiness,
martin



More information about the samba-technical mailing list