[RFC] Simplify async path based VFS functions: remove tevent and pthreadpool_tevent wrappers

Jeremy Allison jra at samba.org
Mon Jan 14 18:07:26 UTC 2019


On Mon, Jan 14, 2019 at 02:09:51PM +0100, Ralph Böhme via samba-technical wrote:
> On Fri, Jan 11, 2019 at 03:59:52PM -0800, Jeremy Allison wrote:
> > On Fri, Jan 11, 2019 at 11:10:53PM +0100, Stefan Metzmacher wrote:
> > > > A pipeline is running here:
> > > > https://gitlab.com/samba-team/devel/samba/pipelines/43026374
> > > >
> > > > We plan to push this one the pipeline reports success.
> > > 
> > > Pushed to autobuild...
> > 
> > Thanks a *LOT* for this rollback. It makes the async
> > VFS code a lot easier to understand (for me at least).
> 
> It also requires careful explicit impersonation in many places which we
> actually forgot to add.
> 
> Attached patchset adds it, please review&push if happy. Thanks!
> 
> For completeness: https://gitlab.com/samba-team/devel/samba/pipelines/43265119

I'm gonna forgive you, as it was a really big change :-).

RB+ and pushed.

Jeremy.



More information about the samba-technical mailing list