[PATCH] Fix string to integer conversion for occurences in source3

swen swen at linux.ibm.com
Sat Jan 12 07:19:57 UTC 2019


Hi Jeremy

I don't want to start another lengthy discussion about something
which isn't that important at all, therefore, just this one..

The wrapper you suggested is adding the capability to keep the
*real* errno untouched, still being able to catch the errors generated
by the string conversion. Good.

However, this is only needed by few code paths (saw one) and
very inconvenient in handling to the other 99 occurences.

We wouldn't get the promised "less code changes" but
only additional complexity (addtl. var / addtl. function call).

So for almost all occurences there are only disadvantages and
absolutely no gain compared to the inline solution.

Therefore, I'm afraid I cannot provide a patch providing 
the changes you suggested.

Sorry, but thank you very much for your support and guidance.

Cheers Swen

P.S.: If you could agree to the inline solution, proposed by me
initially, adding the special case for conv_str_size() seperatly
I would be more than happy to provide that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190112/d814d48a/signature.sig>


More information about the samba-technical mailing list