DCERPC Security Context Multiplexing (ready for review)

Stefan Metzmacher metze at samba.org
Fri Jan 11 09:54:24 UTC 2019


Hi Jeremy,

> +       istate = talloc(ptr, struct dcesrv_iface_state);
> 
>                  ^^^^^^
>                  I would prefer talloc_zero() here.
> 
> Yes I know you fill in all the elements (including
> linked list pointers) below, but using talloc_zero
> when allocating such things seems safer defensive
> programming to me.
> 
> I've changed my local copy.

If it makes you happy, I'm fine with it:-)

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190111/628b06b6/signature.sig>


More information about the samba-technical mailing list