[PATCH] lib: remove unused function nttime_from_string()

swen swen at linux.ibm.com
Fri Jan 11 08:51:44 UTC 2019


On Fri, 2019-01-11 at 09:31 +0100, Volker Lendecke via samba-technical
wrote:
> On Fri, Jan 11, 2019 at 09:28:22AM +0100, swen via samba-technical
> wrote:
> > Please review and push if happy.
> 
> Can you also remove the prototype in lib/util/time.h?
Oh man, of course.
Sorry for that.

Attached patch updated.

Cheers Swen
-------------- next part --------------
From d1e2a89e262f484f9e144d2d9b608aca6c1d2061 Mon Sep 17 00:00:00 2001
From: Swen Schillig <swen at linux.ibm.com>
Date: Fri, 11 Jan 2019 09:26:29 +0100
Subject: [PATCH] lib: remove unused function nttime_from_string()

Signed-off-by: Swen Schillig <swen at linux.ibm.com>
---
 lib/util/time.h    | 5 -----
 source3/lib/time.c | 9 ---------
 2 files changed, 14 deletions(-)

diff --git a/lib/util/time.h b/lib/util/time.h
index 9b897eb4b6c..1988b330576 100644
--- a/lib/util/time.h
+++ b/lib/util/time.h
@@ -180,11 +180,6 @@ void push_nttime(uint8_t *base, uint16_t offset, NTTIME t);
 */
 NTTIME pull_nttime(uint8_t *base, uint16_t offset);
 
-/**
-  parse a nttime as a large integer in a string and return a NTTIME
-*/
-NTTIME nttime_from_string(const char *s);
-
 /**
   return (tv1 - tv2) in microseconds
 */
diff --git a/source3/lib/time.c b/source3/lib/time.c
index 30ad1ec9a01..6b864253a91 100644
--- a/source3/lib/time.c
+++ b/source3/lib/time.c
@@ -36,15 +36,6 @@
 #define TIME_FIXUP_CONSTANT_INT 11644473600LL
 #endif
 
-
-/**
-  parse a nttime as a large integer in a string and return a NTTIME
-*/
-NTTIME nttime_from_string(const char *s)
-{
-	return strtoull(s, NULL, 0);
-}
-
 /**************************************************************
  Handle conversions between time_t and uint32, taking care to
  preserve the "special" values.
-- 
2.20.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190111/3c90480b/signature.sig>


More information about the samba-technical mailing list