[PATCH] improve a selftest error message

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jan 10 15:27:39 UTC 2019


Hi!

Review appreciated!

Thanks, Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de
-------------- next part --------------
From 43591654d350585f7f26f9bb3d329cedcea9285f Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Fri, 7 Dec 2018 15:14:46 +0100
Subject: [PATCH] selftest: Improve an error message

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 python/samba/tests/getdcname.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/python/samba/tests/getdcname.py b/python/samba/tests/getdcname.py
index de3fd3df5e0..2cf7d252783 100644
--- a/python/samba/tests/getdcname.py
+++ b/python/samba/tests/getdcname.py
@@ -275,7 +275,8 @@ class GetDCNameEx(samba.tests.TestCase):
                                                     flags=netlogon.DS_RETURN_DNS_NAME,
                                                     ex2=False)
         except WERRORError as e:
-            self.fail("Failed to succeed over winbind: " + str(e))
+            self.fail(("get_dc_name (domain=%s,site=%s) over winbind failed: "
+                       + str(e)) % (self.trust_domain, site))
 
         self.assertTrue(response_trust is not None)
         self.assertEqual(response_trust.domain_name.lower(),
-- 
2.11.0



More information about the samba-technical mailing list