[Patch] Stop smbprofile.tdb from growing when level is set to 0

Dylan Stephano-Shachter dshachter at nasuni.com
Wed Jan 9 15:16:20 UTC 2019

On Jan 9 2019, at 5:32 am, Volker Lendecke <Volker.Lendecke at SerNet.DE> wrote:

On Wed, Jan 09, 2019 at 03:51:06AM +0000, Dylan Stephano-Shachter via samba-technical wrote:
smbprofile.tdb grows even when the level is set to 0. I believe this
patch should fix the problem. If there is a better way to deal with
this, by all means, use that instead.

Worthwhile patch, with two small cosmetic nit-picks:

A boolean queried with == true doesn't really look nice. Can you
remove the ==true?

We have a guideline not to exceed 80 chars per line, see README.Coding
in Samba's rootdir for the reasoning. Can you make that multiple



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de<https://link.getmailspring.com/link/1547046840.local-069c3615-22ee-v1.5.2-31660462@getmailspring.com/0?redirect=http%3A%2F%2Fwww.sernet.de&recipient=c2FtYmEtdGVjaG5pY2FsQGxpc3RzLnNhbWJhLm9yZw%3D%3D>
How does this look?
 This e-mail message and all attachments transmitted with it may contain privileged and/or confidential information intended solely for the use of the addressee(s). If the reader of this message is not the intended recipient, you are hereby notified that any reading, dissemination, distribution, copying, forwarding or other use of this message or its attachments is strictly prohibited. If you have received this message in error, please notify the sender immediately and delete this message, all attachments and all copies and backups thereof.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-stop-smbprofile.tdb-from-growing-unnecessarily.patch
Type: application/octet-stream
Size: 1721 bytes
Desc: 0001-stop-smbprofile.tdb-from-growing-unnecessarily.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190109/95edc5a8/0001-stop-smbprofile.tdb-from-growing-unnecessarily.obj>

More information about the samba-technical mailing list