Apply patch for socken listen backlog (FreeBSD)

Osipov, Michael michael.osipov at siemens.com
Tue Jan 8 15:43:50 UTC 2019


Hi Peter,

thanks for your effort. You should really consider creating PRs for them!

Let's see what the Samba devs will say. I have raised an issue with the 
FreeBSD ports system for the backlog issue [1].

Michael

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234753

Am 2019-01-08 um 16:32 schrieb Peter Eriksson:
> FYI,
> 
> I still run the same patch on our local Samba servers (4.7.6 & 4.9.4 right now).
> 
> Actually there are 6 patches we always apply:
> 
> /home/Build/samba/Patches/4.9 % ls -l
> total 39
> -rw-r--r--  1 root  wheel   733 Nov 16 13:23 intel_aesni.patch
> -rw-r--r--  1 root  wheel   700 Dec 27 23:17 lib_crypto_wscript_configure.patch
> -rw-r--r--  1 root  wheel  5952 Nov 16 13:23 listen_backlog.patch
> -rw-r--r--  1 root  wheel   419 Dec 27 18:43 liu_version.patch
> -rw-r--r--  1 root  wheel   421 Dec 21 16:49 unable_to_init.patch
> -rw-r--r--  1 root  wheel   553 Nov 16 13:23 vfs_shadowcopy.patch
> 
> First patch is to make the configure script recognise Intel AESNI on FreeBSD, second is to make sure the right library is used for the MD5 functions (checks for libmd before libmd5), third is the listen backlog stuff, fourth just adds “-LiU” to the printed version numbers, fifth removes a warning message and the last one fixes “Previous Versions”/ZFS snapshots handling. (Not all written by us)
> 
> I include them all below as an “unencoded” tar.gz file :-)
> 
> begin 644 samba-4.9-patches.tar.gz
> M'XL(`/7!-%P``^U:>W/:2!+/O^93S)+:-0Y(2$("F017"&"'6@?O&9R]9TT)
> M:3"JZ+4:R7;V:K_[]8S$2T at 0VXES>^=)RB.AGNZ9Z=>O1U+%X_J+;]PD26II
> M&F(]M&R?W, at -598U694D#4FRK#;E%TC[UA-C+::1$<)40M^/=M'=S at EQ=CS/
> M+NY/TE30O^U%Q,$&H9XM!D9DSK^R#-B/IJH6ZE]N-#30?Z/5T!J-AMP$_6OP
> MXPLD?>5YY+;_<_U;]FR&A!@)(:*&.S4$56R)6CV:VZ&%`R.,/M>Y80C<2.JW
> MU`SM(%JG%1P[WD=?$@3A/OP/%$EN";(B*`I2Y+8JM35=7`6+JB1+4JE:K=YW
> M'HRO+D at -8(UDM:WH;;4E at FVJ+77%]^U;)&BU%JJR/V_?EI!%9LCTO9E]'8>D
> MPJZ.VB7$FCU#%T%D^QX5_;0W3#-Q)M'Q;TE8.4*=#BKS6?`)E=.AZ7#&3>R]
> M'_1^QKW3\^[9N'(H_!K4A$%-<`SO6C"H>UA#AX<@44!K;3&4>#?_.!S_;3P9
> M?,!7H^Z'`?[0[;T?C@:'_V*"#^_T)FZJA^U2]1&CD1]^&;WA6EP8RK8 at A!VH
> ME'N^&]B.[5VC6SN:HR';%=0=C)'MT2B,3;Z%Y:/M\5QZ?W`*HBJ'[[L?!QA&
> MC89X.)H,SF&#Y,P8XE#2+GUOY_H3-!;_8\^8. at 1'/K8]._KZ*6!/_(>'+/ZK
> M4DN1M";/_YHF*\_Q_RG:>F`^%M4Z]>/0)(VZ8T_K`<0T;/JNZWO8="WP6R*:
> MXL7E\"R)H[(L2#J2=`C.;6EW?/XBUBE7B/HRB\[`6%+%)EB$E(G.LM1D\3GI
> M6(0^.)CZOH/\3Z]+B-VY]!J;T1WJH)0Y=@FEQC5$'I`*4><NJER3"%N?/=R[
> M&)T.STZ'YX/*T='KDG!P`-&QLN300:.K\_,C].]2-?<)^NDG!*Q(;%M)K)<8
> M+<SA8,:#WJQ"(XN$80V5K[B?H<A'S,]LP[%_)ZC,:0_*RPFB=(+_],HP'7CX
> MQ[>,8\S_02'8##\'$`#2/(F7Z>YK1(-]^$]IJ0G^5]26!H02Q`'I&?\]2<OX
> M/P=1S$$3>ZAOVX,?VM<IC&IQ&"6UE4:[T=QP?V7;_?=R7GE_"RE*6VTR;-;0
> MP>>53>]7:S+<\K_,]TL,S7A^M`ZE3J]&O3&`@\KAA[XV!&=C&&I*+>CFQ`!W
> MI!UV6W<M39P?UA+L8,Z)^0EF:'8F84P6@&L?5V"QSI5^IDNNPA:,6:"934DE
> M]&6"BN04B=F24WWD at JI?*BA?2*^'00Y>"%J7TN.IH)>81G+3MZ\)C0K5`XK_
> MWK[SO]"2^$\CXN&I`?OK7S\U_I,;&C__V:C_U5;S.?X_12NH_\W(@DC-_1!P
> MF_D)6P:!:]'<JK at +*;=J_D+*!U?[.SGFU/E-1<_D$J4A,R29=`F2#$D4AQZ`
> M3`:^_H`P(["?`$HF;E*965!N2@#-JMN_.P%F\P!DN>E3'%DB#A_9F!]6*+&/
> M!Y>7E7(R*F6%9H;M$`L)Z$<**+"&V%/PRGF"!TW'IP3$P5V!]BS?I,*=Z]2I
> M.[7\B`7CNFM3LYZ(2:0LW!WHMC;VO at RV='U?!AL*:S+HKS1%79<:C3TF\"A!
> M6EN!_RU15S49*L\-RY!J<"?79)691?4-E]L.C-!P`>R'R(.^DU%;*J:<DR=3
> M3-\IG^4]C3X'P(R=$5V3,(\`)N[1-I]#ISR/HJ!=K]_>WHK\%X!DUW5^5>]/
> M^LF5`/M2/H%Y6R3!6;;OP>W!&[:"D\G<IFBU%AH0TY[9A*)H3MAIEQ$[$:*L
> M.O%G_#<VM=`S'`0L<M<,99%QA[S8G0(_&/1;3&*PX$GO%[9TCR0G.T<BC)\`
> MOY5LF`C#;@::&Z$%3%T;;CP+N3Z-D!^0T(A8300H)"(NA>'$F_E01E(84G%C
> M<WZ$J&LX#F.UF"3GPD2]J?/EPC;4-_<!?KDQG)BD.Y\NN7P"RI?>U/DC/BJC
> M]9,BAUN4MK9G.K%%ZHYO&HXXW[+6`KHM]RF at 2P(EX&X)"B:E+3'[W8F[]\@M
> M"I--]3A3<+>TF@[NP#L6)NNOT+MX-F/&P\P$2MJ8$@0YTDN.^IC.F&E$H<%T
> M]:I>0B]AEZ$21^^ZO9\GE]W>`(\G<(G'P[\/4%-E at 1:X+JPN#:I'2P.S/<1<
> MG+$2%JS&'][U\?EP/!F,,&-[?G&&--@!X-//6/$N?M5=_- at 6(+[@T=*Z7=L,
> M(0:#95N4K?W6`*N=$C!,`F9)P939^F]LWS&8P8D;ZQ^_[UX.1V?XX_#BO#L9
> M7HSPU7C0P[]VAQ-TK#%%[K,R`,$P]7KLD3OPW(A8.6EY!VVAM>70/MKB"GCF
> M6%U+UK1-JSM666[F?Y/4#%`MBBFD7-<(L!=A$H9^B&>A[^+8L^\J<._Y29*\
> M]D$O+(\F61QRN+E*U2&A8!O"29JD642K(2U)Z?O(OB3%F^C-,L$_;,Y[+(!'
> M)/!BPX(K=X?ZLX2%NL\2/AB3[6*8H_5C6<G$FE9+KS51E76MM,`_.'/\J>%0
> MD<[]6VQ8%N9!AH3XUOZ=Y8T.BJ`F?+U&Z5/LD!OBP"-%8HI=LLA3'E"QT+_.
> M@(=([!J49:EM_MCR7</V5 at 3=./)?'T"8L$A`/(L%`-]#"S*0`?F/QX$M%NFS
> M#JC>H62O[L/`Q)2$-R1<N]QA`@7TA9900)]&`EV0-20=MP&D:<?WB at 0[^.;9
> MA2YG<Y"F\T-?35_&`^XP?ARM(?4U]V6>1X03ALNW?7OMX7T]NC]X=W56D6JH
> M4CY-@#K,(H5#H/+`#@A*0=*/M)UB>'[*B_A#S+`C@/HHY+$@C0!,&%MFL]EB
> MRTPZODRPJ3'P2C9LP1E$>KXG3,%,/S%;@]S#D1I[_1A$2<8YH+"F!<7ZBKFA
> ML<45[UA.*GS\'G8ZH,;,+D+M`P57@",3]B9ETEYLYZH"VMZL#?VSG=,5;B!)
> M]U]L(!X$%O"`0ALI-(\]@8'!F?K><+!!51@$-J@>G0NVN&T[O":UFHV,PR]>
> M\ZR]YT&O[FWVB0Y/UTR>*6RAY6)K7UEK-6?$#ILH,G/8!`P5C8=]CV0,O9V^
> M!BKO-/>T\N<SV&\.<60[E&W]S':BG2:Q15EH%EN4.?AP]YN`O;(+S$-6)#US
> M=',L\:,;WB7N3N[LJ"(?K;Q]76_,R8MT^N7Z3*''K%+>.*M9O*QC8O?HY=;V
> MIK9G6<N+'9K)H2W430[MHQVW@&>.?A2IF4'OH#&)`3G>)\<HX)K\*P\4`30#
> M+#R#\FMF<5P%>XI"DUV94#ZA5ZDRV*D7B\SL\19D`YVE\P(8=H=-QP:FM,)"
> M.?NWIN'EH#>[%`U#4*Z4@@&OBZ7(4@$W64I>40?Q%/,4P["EX4"TJB0!$B=;
> MLWA+?;3("BC=NH4F%K/A3%+L("MR at T=,15F>9[+I+86QR+%ASLN2 at UAYA=+&
> MP+PLF2'87&Y^=MP2F<Q<U9*9:XV-F8?VS0.GOC$R=^X9B@=-_GN?WS^VL?<_
> M-S.*Z=RP_%O3#SX_^?<_LJ3)V?<_FO;\_<^3M#W)RO6MV"%TS40PLQ%E1\XJ
> M'E*8NHJ'//K\:3?KG$2FZHW,.R)95_E+HK1/H`:TGP"UX!E'Z^DOO*Y:W+!#
> MO?[PDL-*_ET1"R8_C";LV'-R-<;#,;[XN9(<#QVM(,F*8/"7J^YY2E!#J]^[
> MO=Y@/,;]P6 at XZ!]MX<P8\@BR?)(<K,^-&\(C&PI(Z-J4VE"!I&`3KJAG!)8=
> MKA<@RU6)4X,FQ2K#G]_;4)_;-VG)^_\8`_)@IO$]OO^'AXWT^R^II3:3[_\U
> M[3G^/T7+^_[KX^!R/+P8K7WJE7R5)4.(5-H-7=2/=<C5^25$ALGV>%47CQ6E
> MI6>K?:51TQ@`9!V+L2\1$DX0*C=$291"4Q$^$L_RPX^)H9:+/D5ZR4<^I+&1
> M#VPE8=S]\*Z+TT5#/^I?7.+QU>GI\*^=4G77TW/[JH1R"7[I3GKO.\^1][D]
> /M^?V;=I_`%;8*PT`.@``
> `
> end
> 
> - Peter
> 
> 
>> On 8 Jan 2019, at 15:53, Osipov, Michael <michael.osipov at siemens.com> wrote:
>>
>> Folks,
>>
>> a year ago Peter Eriksson [1] provided a decent patch [2] for the listen queue overflow on FreeBSD. We have been hit by this too twice today.
>>
>> I can see that this patch has not been applied. Is there any obstacle here? Can we apply this? Shall I provide a PR on GH? We'd need it for at least 4.8 or 4.7. 4.9 is not yet available on the FreeBSD ports tree.
>>
>> Regards,
>>
>> Michael
>>
>> [1] https://lists.samba.org/archive/samba/2018-January/213321.html
>> [2] https://people.ifm.liu.se/peter/patches/samba/socket_listen_backlog.patch
> 



More information about the samba-technical mailing list