We messed up smbc_readdirplus :-(

[Stefan Metzmacher]

Hi Jeremy,

>> We actually *have* this data as returned
>> from the SMB2_FIND_ID_BOTH_DIRECTORY_INFO
>> call when enumerating the directory, but
>> then throw it away when populating the
>> struct libsmb_file_info struct.
>>
>> I think the best way forward is to
>> add a smbc_readdirplus_ex() call that
>> returns a new 'struct libsmb_file_info_ex'
>> struct that includes these extra fields.
>>
>> Comments from other Samba Team members ?
>>
>> I wish we'd gotten it right the first
>> time though, but that's probably my (our?)
>> fault :-(.
> 
> Or what about smbc_readdirstat() that
> just returns a name plus a filled-in
> stat struct using the same internal
> algorithms that smbc_stat does ?

But 'struct stat' would loose information.
and 'struct statx' is not portable.
And 'short_name' would also be dropped?

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190108/3e57ed82/signature.sig>