We messed up smbc_readdirplus :-(

Jeremy Allison jra at samba.org
Mon Jan 7 22:20:30 UTC 2019

Hi Puran,

I'm looking at Red Hat bug:


and realized we made a mistake in the
implementation of smbc_readdirplus().

struct libsmb_file_info

should have been defined as a *superset*
of the stat struct that smbc_stat
returns, but currently it is missing
the st_ino, st_dev, st_mode and st_blocks
fields in order to be a superset of struct stat.

We actually *have* this data as returned
call when enumerating the directory, but
then throw it away when populating the
struct libsmb_file_info struct.

I think the best way forward is to
add a smbc_readdirplus_ex() call that
returns a new 'struct libsmb_file_info_ex'
struct that includes these extra fields.

Comments from other Samba Team members ?

I wish we'd gotten it right the first
time though, but that's probably my (our?)
fault :-(.



More information about the samba-technical mailing list