[PATCH] cifs: Fix a debug message

Paulo Alcantara paulo at paulo.ac
Sat Jan 5 16:09:58 UTC 2019


Thanks!

Reviewed-by: Paulo Alcantara <palcantara at suse.de>


On January 5, 2019 9:25:29 AM GMT-03:00, Dan Carpenter <dan.carpenter at oracle.com> wrote:
>This debug message was never shown because it was checking for NULL
>returns but extract_hostname() returns error pointers.
>
>Fixes: 93d5cb517db3 ("cifs: Add support for failover in
>cifs_reconnect()")
>Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>---
> fs/cifs/connect.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>index f66529679ca2..683310f26171 100644
>--- a/fs/cifs/connect.c
>+++ b/fs/cifs/connect.c
>@@ -433,9 +433,10 @@ static void reconn_inval_dfs_target(struct
>TCP_Server_Info *server,
> 	kfree(server->hostname);
> 
> 	server->hostname = extract_hostname(name);
>-	if (!server->hostname) {
>-		cifs_dbg(FYI, "%s: failed to extract hostname from target: %d\n",
>-			 __func__, -ENOMEM);
>+	if (IS_ERR(server->hostname)) {
>+		cifs_dbg(FYI,
>+			 "%s: failed to extract hostname from target: %ld\n",
>+			 __func__, PTR_ERR(server->hostname));
> 	}
> }
> 
>-- 
>2.17.1

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


More information about the samba-technical mailing list