[PATCH] Evaluate 'disable netbios' parameter

[Justin Stephenson]

Thank you for the review, I updated the patch with the suggestions
discussed here.

Updated patch attached, please review.

On Fri, Dec 21, 2018 at 1:11 PM Jeremy Allison <jra at samba.org> wrote:
>
> On Fri, Dec 21, 2018 at 09:04:09AM +0100, Stefan Metzmacher via samba-technical wrote:
> > Hi Justin,
> >
> > > The following patches evaluate the 'disable_netbios' option prior to making
> > > calls to cli_connect_nb() in several places, this bug was reported by a
> > > RHEL customer seeing outbound 'netbios-ssn' traffic on port 139 with
> > > disable_netbios set in smb.conf.
> > >
> > > Gitlab CI Passed, merge request below:
> > > https://gitlab.com/samba-team/samba/merge_requests/181
> > >
> > > Please review.
> >
> > If we want to make sure we never generate traffic on port 139,
> > don't need to catch that in smbsock_connect_send()
> > if port 139 is explicitly passed. And don't try a fallback to that?
> >
> > What do others think?
>
> Yep, that would be the lowest level to catch it !
>
> We could return NT_STATUS_NOT_SUPPORTED on any
> 139 connect, and let the upper levels print
> the debugs as required.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jstephen_honor_disable_netbios.patch
Type: text/x-patch
Size: 6133 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190104/cbfb0631/jstephen_honor_disable_netbios.bin>