[PATCH] Fix string to integer conversion

swen swen at linux.ibm.com
Thu Feb 28 10:33:47 UTC 2019

Oops, forgot one comment

On Thu, 2019-02-28 at 10:33 +0100, Ralph Böhme via samba-technical
> Hi Swen,
> Finally, I'm not sure we want the last patch being part of this
> patchset. Once 
> strtoul_err() does that check, all callers must be updated to remove
> their own 
> checks for the same error.

I'll leave it in for now and let Jeremy decide.
In fact I was thinking if we should change the return value for this
one to something unique and therefore make it detectable by callers.

Anyway, I guess I've opened another P-box here :-)

Cheers Swen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190228/3045d380/signature.sig>

More information about the samba-technical mailing list