[PATCH] Fix string to integer conversion

Ralph Böhme slow at samba.org
Thu Feb 28 09:33:25 UTC 2019

Hi Swen,

On Tue, Feb 26, 2019 at 04:45:37PM +0100, swen wrote:
>On Tue, 2019-02-26 at 06:13 -0800, Jeremy Allison wrote:
>> On Tue, Feb 26, 2019 at 03:11:48PM +0100, Ralph Böhme wrote:
>> > If you're happy with the fixups, just fixup' em.
>> >
>> > 1. commit messages
>> > 2. doxygen comments
>> > 3. wait for Jeremy :)
>> Being at the Vault Conference and working on SMB3+posix
>> bugs I've completely lost the plot on this one :-).
>> Can you resend the full patchset when Ralph is
>> happy and I'll just re-review from scratch.
>The patchset contains now everything, I had to modify/fix and
>FIXUPs suggestd by Ralph B.
>I hope we have it all now.
>The patchset is compile tested and currently running at gitlab.
>Thanks to all to help out here !
>Please review and piush if happy.

thanks, much better!

There are still a few places where error is not initialized to 0. Can you check 

Furthermore, it seems in the commit

  passdb: Use wrapper for string to integer conversion

the hunks changing source3/utils/net_registry.c and 
source3/utils/net_rpc_registry.c should have been applied to the previous 

Can you fix that any submit an updated patchset? Please also rerun CI with the 
patchset and please include the link in the mail.

Finally, I'm not sure we want the last patch being part of this patchset. Once 
strtoul_err() does that check, all callers must be updated to remove their own 
checks for the same error.

Thanks for your patience with us nasty and grumpy reviewers! :)


Ralph Boehme, Samba Team                https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46

More information about the samba-technical mailing list