[PATCH] wafsamba: Fix detection of HAVE_LARGEFILE with python2

Lukas Slebodnik lslebodn at fedoraproject.org
Wed Feb 27 22:38:44 UTC 2019


On (27/02/19 06:47), Noel Power wrote:
>Hi Lukas,
>
>Apologies, while at the time this bug reared it's head I remembered your
>patch (because I RB'd it) but we eventually decided to fix all
>occurrences with a different patch, I rudely never thought to update
>you. I would find that very annoying if it were me so I am sorry about that.
>
>Noel
>

No problem, I get used to that some of my patches are staled for very long time
and in some cases there is a different fix without any comment.

Usually I can notice it when rebasing downstream patches.
e,g, commit 8294e68a4175e6116b38869866c42a1b7ba55b6a
and thread https://lists.samba.org/archive/samba-technical/2019-January/132067.html

+ few more examples from older history


I agree that fix for bug 13777 is nicer.
And good to know that I can drop downstream patch :-)

LS



More information about the samba-technical mailing list