[PATCH] Fix string to integer conversion

swen swen at linux.ibm.com
Tue Feb 26 08:37:52 UTC 2019


On Mon, 2019-02-25 at 21:10 +0100, Volker Lendecke via samba-technical
wrote:
> On Mon, Feb 25, 2019 at 06:56:18PM +0100, Ralph Böhme via samba-
> technical wrote:
> > The strtoul API is broken and we shouldn't add it to Samba. I know
> > it's a
> > pita to change the many callers once again, I'm willing to lend a
> > helping
> > hand here.
> 
> Maybe looking somewhere else helps: What about
> 
> https://man.openbsd.org/strtonum.3
Hmm, this is not too different from what we're trying to implement now.
But I'm a bit hesitant towards the min/max parameters, that seems a bit
"effortful" if things(valid ranges) do change and easy to forget about.

> 
> as an API? Although this might start to become a discussion about the
> color of the bike-shed. Ours is transparent by the way. Go looking
> for
> it on
> 
> https://www.google.de/maps/@51.536622,9.9231612,3a,30y,67.77h,92.42t/data=!3m8!1e1!3m6!1sAF1QipPnfcnS9T_sR3j4E0x_y407vmQaev8UmEDk93_s!2e10!3e11!6shttps:%2F%2Flh5.googleusercontent.com%2Fp%2FAF1QipPnfcnS9T_sR3j4E0x_y407vmQaev8UmEDk93_s%3Dw203-h100-k-no-pi-0-ya51.086464-ro-0-fo100!7i8704!8i4352
> 
> :-)
> 
with very few bikes in it...maybe because of the lack of colour :-)

Cheers Swen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190226/4288430c/signature.sig>


More information about the samba-technical mailing list