[PATCH] Fix string to integer conversion
slow at samba.org
Mon Feb 25 21:47:54 UTC 2019
> Am 25.02.2019 um 21:10 schrieb Volker Lendecke <Volker.Lendecke at SerNet.DE>:
> On Mon, Feb 25, 2019 at 06:56:18PM +0100, Ralph Böhme via samba-technical wrote:
>> The strtoul API is broken and we shouldn't add it to Samba. I know it's a
>> pita to change the many callers once again, I'm willing to lend a helping
>> hand here.
> Maybe looking somewhere else helps: What about
that's going in the right direction in giving an reliable error for the "The string did not consist solely of digit characters." case. Though I wonder if that applies to the empty string as well. Arguably the empty string could be seen as a string that does not "consist solely of digit characters."
I think checking for upper and lower bounds can be done in the caller, most existing callers don't need this iirc.
> as an API? Although this might start to become a discussion about the
> color of the bike-shed. Ours is transparent by the way. Go looking for
> it on
"Da ist keine Butter!". :)))
More information about the samba-technical