[PATCH] Fix string to integer conversion

Swen Schillig SCHILLIG at de.ibm.com
Mon Feb 25 13:28:21 UTC 2019

...and another comment

-----"samba-technical" <samba-technical-bounces at lists.samba.org> wrote: -----
To: slow at samba.org, jra at samba.org, samba-technical at lists.samba.org
From: Swen Schillig via samba-technical 
Sent by: "samba-technical" 
Date: 02/25/2019 02:13PM
Subject: [PATCH] Fix string to integer conversion

I guess I misunderstood your comment below

>The patchset introduces an additional error check in the callers in some places where only the return error is checked,
>causing an error log message or even a failure in the caller.

There is no "additional" error check introduced, there never existed one before !
...and there is no "return error". 
One cannot distinguish between an error or a simple zero being returned.
So to make that clear, in case of a conversion error we kept processing as if there wasn't one.

Cheers Swen

More information about the samba-technical mailing list