[PATCH] Removed unused header files
Jeremy Allison
jra at samba.org
Fri Feb 22 19:47:01 UTC 2019
On Fri, Feb 22, 2019 at 01:20:22PM +0100, Andreas Schneider via samba-technical wrote:
> Hi,
>
> attached is a patchset which removes some unused header files.
>
>
> Review is much appreciated!
LGTM, obvious goodness ! RB+ and pushed.
Jeremy.
>
>
> Andreas
>
> --
> Andreas Schneider asn at samba.org
> Samba Team www.samba.org
> GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
> From db295c5894269b8c23f0972b71b0fba83eda7221 Mon Sep 17 00:00:00 2001
> From: Andreas Schneider <asn at samba.org>
> Date: Tue, 6 Nov 2018 17:36:31 +0100
> Subject: [PATCH 1/5] s4:dns_crypto: Remove unused include of hmac_md5.h
>
> Signed-off-by: Andreas Schneider <asn at samba.org>
> ---
> source4/dns_server/dns_crypto.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/source4/dns_server/dns_crypto.c b/source4/dns_server/dns_crypto.c
> index 8c7502628d5..6d2b8648757 100644
> --- a/source4/dns_server/dns_crypto.c
> +++ b/source4/dns_server/dns_crypto.c
> @@ -20,7 +20,6 @@
> */
>
> #include "includes.h"
> -#include "lib/crypto/hmacmd5.h"
> #include "system/network.h"
> #include "librpc/ndr/libndr.h"
> #include "librpc/gen_ndr/ndr_dns.h"
> --
> 2.20.1
>
>
> From 0f2f5d5e1d7c11f2cd628292646be2a63a0d0143 Mon Sep 17 00:00:00 2001
> From: Andreas Schneider <asn at samba.org>
> Date: Fri, 22 Feb 2019 13:03:04 +0100
> Subject: [PATCH 2/5] s3:auth: Remove unused arcfour.h header from
> server_info.c
>
> Signed-off-by: Andreas Schneider <asn at samba.org>
> ---
> source3/auth/server_info.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/source3/auth/server_info.c b/source3/auth/server_info.c
> index 2c48d1bb7a9..527a7dbce60 100644
> --- a/source3/auth/server_info.c
> +++ b/source3/auth/server_info.c
> @@ -20,7 +20,6 @@
> #include "includes.h"
> #include "auth.h"
> #include "lib/util_unixsids.h"
> -#include "../lib/crypto/arcfour.h"
> #include "../librpc/gen_ndr/netlogon.h"
> #include "../libcli/security/security.h"
> #include "rpc_client/util_netlogon.h"
> --
> 2.20.1
>
>
> From f8475ce35d494c80a24b28cae4e0f9b3b1d385d7 Mon Sep 17 00:00:00 2001
> From: Andreas Schneider <asn at samba.org>
> Date: Fri, 22 Feb 2019 13:07:15 +0100
> Subject: [PATCH 3/5] s3:auth: Remove unused arcfour.h from auth_util.c
>
> Signed-off-by: Andreas Schneider <asn at samba.org>
> ---
> source3/auth/auth_util.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/source3/auth/auth_util.c b/source3/auth/auth_util.c
> index d78dbed14b2..7f80055fda8 100644
> --- a/source3/auth/auth_util.c
> +++ b/source3/auth/auth_util.c
> @@ -25,7 +25,6 @@
> #include "auth.h"
> #include "lib/util_unixsids.h"
> #include "../libcli/auth/libcli_auth.h"
> -#include "../lib/crypto/arcfour.h"
> #include "rpc_client/init_lsa.h"
> #include "../libcli/security/security.h"
> #include "../lib/util/util_pw.h"
> --
> 2.20.1
>
>
> From 3ccf8eeb16b106e9b9cdb1c321c5ab5a8bc5ac4e Mon Sep 17 00:00:00 2001
> From: Andreas Schneider <asn at samba.org>
> Date: Fri, 22 Feb 2019 13:09:40 +0100
> Subject: [PATCH 4/5] s3:rpc_server: Remove unused arcfour.h from netlogon
>
> Signed-off-by: Andreas Schneider <asn at samba.org>
> ---
> source3/rpc_server/netlogon/srv_netlog_nt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c
> index 9b9947455ed..a846a728f24 100644
> --- a/source3/rpc_server/netlogon/srv_netlog_nt.c
> +++ b/source3/rpc_server/netlogon/srv_netlog_nt.c
> @@ -38,7 +38,6 @@
> #include "../libcli/security/security.h"
> #include "../libcli/security/dom_sid.h"
> #include "librpc/gen_ndr/ndr_drsblobs.h"
> -#include "lib/crypto/arcfour.h"
> #include "lib/crypto/md4.h"
> #include "nsswitch/libwbclient/wbclient.h"
> #include "../libcli/registry/util_reg.h"
> --
> 2.20.1
>
>
> From 39f3d18c143e4a524c1677f35c391d746851b160 Mon Sep 17 00:00:00 2001
> From: Andreas Schneider <asn at samba.org>
> Date: Fri, 22 Feb 2019 13:10:30 +0100
> Subject: [PATCH 5/5] s3:winbindd: Remove unused arcfour.h from PAM handling
>
> Signed-off-by: Andreas Schneider <asn at samba.org>
> ---
> source3/winbindd/winbindd_pam.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
> index 1e6591aea65..2d533773fb9 100644
> --- a/source3/winbindd/winbindd_pam.c
> +++ b/source3/winbindd/winbindd_pam.c
> @@ -32,7 +32,6 @@
> #include "../librpc/gen_ndr/ndr_netlogon.h"
> #include "rpc_client/cli_netlogon.h"
> #include "smb_krb5.h"
> -#include "../lib/crypto/arcfour.h"
> #include "../libcli/security/security.h"
> #include "ads.h"
> #include "../librpc/gen_ndr/krb5pac.h"
> --
> 2.20.1
>
More information about the samba-technical
mailing list