FALL_THROUGH attribute and AIX build

[Andreas Schneider]

On Thursday, February 21, 2019 4:40:11 AM CET Amitay Isaacs wrote:
> Hi Andreas,
> 
> On Tue, Feb 19, 2019 at 6:49 PM Andreas Schneider <asn at samba.org> wrote:
> > On Tuesday, February 19, 2019 8:24:13 AM CET Amitay Isaacs via
> > samba-technical> 
> > wrote:
> > > Hi,
> > 
> > Hi Amitay,
> > 
> > > Attached is a potential patch to socket_wrapper.
> > 
> > could you please fork https://gitlab.com/cwrap/socket_wrapper and push to
> > your private branch to see if the CI succeeds with your change?
> 
> CI fails mysteriously with following error which doesn't make sense
> because I have removed those lines.
> 
> ----------------------------
> [  1%] Building C object
> src/CMakeFiles/socket_wrapper.dir/socket_wrapper.c.o
> /builds/amitayisaacs/socket_wrapper/src/socket_wrapper.c:613:3: error:
> expected expression <--[clang]
>                 FALL_THROUGH;
>                 ^
> /builds/amitayisaacs/socket_wrapper/src/socket_wrapper.c:632:3: error:
> expected expression <--[clang]
>                 FALL_THROUGH;
>                 ^
> 2 errors generated.
> ----------------------------
> 
> I can build using clang 7.0.1 with -DPICKY_DEVELOPER on my laptop (fedora
> 29).

That doesn't seem to be a problem.

It fails because what it found in "ADDED DEFECTS". Could you fix those too, 
then it should be fine :-)


Thanks,


	Andreas

-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D