[PATCH] CTDB recovery lock fixes and more scary example setting (bug #13790)

[Martin Schwenke]

The motivation for this patch set is that someone who works a lot with
CTDB told me that the example setting in 4.9 isn't scary enough.  It is
too easy for an admin to simply uncomment it in the installed example
configuration file and then struggle to understand the likely failure
mode (i.e. nodes other than the recovery master are able to take the
recovery lock).

So, I'd like 4.10 to have a scarier default.  :-)

So, why is it a patch set rather than a single patch?

* I really want an invalid recovery lock setting to cause a node to be
  banned.  This makes the misconfiguration more obvious.

* There was no test for the case where the recovery lock is explicitly
  set to use a helper (as opposed to a lock file).

* The code that constructs the command-line arguments for the helper
  was awful.

Please review and maybe push...

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patch
Type: text/x-patch
Size: 16893 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190220/ff27c4f0/ctdb.bin>