PATCH: ctdb: buffer write beyond limits

[Volker Lendecke]

On Tue, Feb 19, 2019 at 09:26:17AM +0100, swen via samba-technical wrote:
> On Mon, 2019-02-18 at 15:57 -0800, Jeremy Allison wrote:
> > On Mon, Feb 18, 2019 at 06:22:49PM +0100, swen via samba-technical
> > wrote:
> > > 
> > This is *way* too complex to even understand as a comment.
> > 
> > Please just add the buffer overrun/overflow checks.
> > 
> > That way we *KNOW* it's safe and don't need to read
> > "War and Peace" to understand.
> > 
> > NAK until then !
> 
> Next try...this time with explicit check.

https://wiki.sei.cmu.edu/confluence/display/c/INT30-C.+Ensure+that+unsigned+integer+operations+do+not+wrap

has a good introduction to the issue.

Regards,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de