[PATCH] Improve logging for localauth MIT Kerberos plugin

Noel Power nopower at suse.com
Mon Feb 18 10:19:41 UTC 2019

On 18/02/2019 10:02, Andreas Schneider wrote:
> On Monday, February 18, 2019 10:29:04 AM CET Noel Power via samba-technical 
> wrote:
>> Hi Andreas
> Hi Noel,
>> On 15/02/2019 09:52, Andreas Schneider via samba-technical wrote:
>>> Hello,
>>> attached is a patch to improve the logging for the MIT KRB5 localauth
>>> plugin.
>>> Review is much appreciated.
>>> Thanks,
>>> 	Andreas
>> initially I thought this was maybe the wrong patch attached (or wrong
>> commit message) I saw was the reorganization to fix the leaked principle
>> (but took me a while to see the log part). Not sure if the leak fix
>> deserves a separate patch or just the commit message needs to mention
>> it. other than this lgtm RB
> Thanks for looking into that.
> I don't see a leak fix in that patch. As the princ_str is user later in the 
> log message too, we need to keep it around till we printed it and then free 
> it. So the call for freeing it just got moved to the end. So it made sense to 
> use a "destructor" for freeing it.

you are right,  I missed the second call to krb5_free_unparsed_name in
the first hunk, looked like a leak fix to me, perhaps I should just go
back to bed, sorry for the noise.


More information about the samba-technical mailing list