[PATCH] fix incorrect use of split in samba-tool dns add SRV/SOA/MX (was Re: small patch for samba-tool dns add command)

Andreas Schneider asn at samba.org
Mon Feb 18 10:09:52 UTC 2019


On Friday, February 15, 2019 2:44:37 PM CET Denis Cardon via samba-technical 
wrote:
> Hi Andreas,

Hi Denis,

> I've followed the directives from samba wiki [1] to format the patch. I
> hope it looks better now. If it is not ok, I'll be glad to have some
> help.

I'm sorry, but your patch doesn't seem to work. Autobuild failed twice in the 
same test:

[92(561)/104 at 2m35s] samba.tests.samba_tool.dnscmd(chgdcpass:local)
-1 is not None : exit[-1] stdout[] stderr[ERROR(runtime): uncaught exception - 
(8242, 'WERR_DS_INVALID_DN_SYNTAX')
  File "/memdisk/asn/a/b2448134/samba-ad-dc-2/bin/python/samba/netcmd/
__init__.py", line 184, in _run
    return self.run(*args, **kwargs)
  File "/memdisk/asn/a/b2448134/samba-ad-dc-2/bin/python/samba/netcmd/dns.py", 
line 944, in run
    raise e
  File "/memdisk/asn/a/b2448134/samba-ad-dc-2/bin/python/samba/netcmd/dns.py", 
line 940, in run
    0, server, zone, name, add_rec_buf, None)
]: Failed to addrecord 
.COM 1 with type MX.
-1 is not None : exit[-1] stdout[] stderr[ERROR(runtime): uncaught exception - 
(8242, 'WERR_DS_INVALID_DN_SYNTAX')
  File "/memdisk/asn/a/b2448134/samba-ad-dc-2/bin/python/samba/netcmd/
__init__.py", line 184, in _run
    return self.run(*args, **kwargs)
  File "/memdisk/asn/a/b2448134/samba-ad-dc-2/bin/python/samba/netcmd/dns.py", 
line 944, in run
    raise e
  File "/memdisk/asn/a/b2448134/samba-ad-dc-2/bin/python/samba/netcmd/dns.py", 
line 940, in run
    0, server, zone, name, add_rec_buf, None)
]: Failed to addrecord 
.COM 0 0 0 with type SRV.
UNEXPECTED(failure): 
samba.tests.samba_tool.dnscmd.samba.tests.samba_tool.dnscmd.DnsCmdTestCase.test_accept_valid_commands(chgdcpass:local)


Do you know how to run the test?


make test TESTS="samba.tests.samba_tool.dnscmd.chgdcpass.local"


Let me know if you need help.


Cheers,


	Andreas


-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D





More information about the samba-technical mailing list