[PATCH] fix incorrect use of split in samba-tool dns add SRV/SOA/MX (was Re: small patch for samba-tool dns add command)

Rowland Penny rpenny at samba.org
Fri Feb 15 14:05:57 UTC 2019


On Fri, 15 Feb 2019 15:02:53 +0100
Andreas Schneider via samba-technical <samba-technical at lists.samba.org>
wrote:

> On Friday, February 15, 2019 2:44:37 PM CET Denis Cardon via
> samba-technical wrote:
> > Hi Andreas,
> 
> Hi Denis,
> 
> > 
> > I've followed the directives from samba wiki [1] to format the
> > patch. I hope it looks better now. If it is not ok, I'll be glad to
> > have some help. By the way, the wiki does not mention the "Signed
> > off by" string, should I add that on the wiki?
> 
> Yes please add it to the wiki!
> 
> 
> The patch looks fine, RB+ by me.
> 
> Second review needed!
> 
> 
> 	Andreas
> 

RB+ please push Andreas

Rowland



More information about the samba-technical mailing list