[PATCH] fix incorrect use of split in samba-tool dns add SRV/SOA/MX (was Re: small patch for samba-tool dns add command)

Andreas Schneider asn at samba.org
Fri Feb 15 14:02:53 UTC 2019

On Friday, February 15, 2019 2:44:37 PM CET Denis Cardon via samba-technical 
> Hi Andreas,

Hi Denis,

> I've followed the directives from samba wiki [1] to format the patch. I
> hope it looks better now. If it is not ok, I'll be glad to have some
> help. By the way, the wiki does not mention the "Signed off by" string,
> should I add that on the wiki?

Yes please add it to the wiki!

The patch looks fine, RB+ by me.

Second review needed!


Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D

More information about the samba-technical mailing list