[PATCH] fix incorrect use of split in samba-tool dns add SRV/SOA/MX (was Re: small patch for samba-tool dns add command)

Denis Cardon dcardon at tranquil.it
Fri Feb 15 13:44:37 UTC 2019

Hi Andreas,

Le 02/15/2019 à 01:19 PM, Andreas Schneider a écrit :
> On Friday, February 15, 2019 11:43:42 AM CET Denis Cardon via samba-technical
> wrote:
>> Hi everyone,
> Hi Denis!!
>> I had an issue with samba-tool dns add SRV command this morning. I
>> filled a bugzilla issue and added a small patch [1]. If one add 2 space
>> characters between SRV record arguments, one get a misleading error
>> message (incorrect number of arguments), which is due to the incorrect
>> use of split() command...
> thank you very much for your contribution.
> Could you please send the Certificate of Origin?

ok, mail sent!

> See https://www.samba.org/samba/devel/copyright-policy.html
> I can help you making it a git patch then :-)

I've followed the directives from samba wiki [1] to format the patch. I 
hope it looks better now. If it is not ok, I'll be glad to have some 
help. By the way, the wiki does not mention the "Signed off by" string, 
should I add that on the wiki?




> Best regards,
> 	Andreas

Denis Cardon
Tranquil IT Systems
Les Espaces Jules Verne, bâtiment A
12 avenue Jules Verne
44230 Saint Sébastien sur Loire
tel : +33 (0)

Samba install wiki for Frenchies : https://dev.tranquil.it
WAPT, software deployment made easy : https://wapt.fr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_bugzilla_13788.patch
Type: text/x-patch
Size: 1726 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190215/e22d4f60/patch_bugzilla_13788.bin>

More information about the samba-technical mailing list